gsdx-hw: Adjust GSC_Bully crc hack.

Previous skip value 6 wasn't enough and caused some visual issues on the
ntsc version. Use value of 8 instead.

Issue reported by ozzie212121 on discord.

common: Silence -Wunused-function clang warnings. (#3127)

v2: Use pragma instead of .
v3: Silence warnings with older clang versions too.

gsdx-hw: Purge impact screen crc hack for Burnout Revenge.

Effect is properly rendered with depth emulation, so far only Burnout
Revenge triggered the crc hack from my testing.

Triggering the draw is done when the player car crashes.

Onepad: Update to latest controller database.

spu2-x: Fix crash with an invalid output module. (#3125)

* spu2-x: Fix crash with an invalid output module.

This will default to SDLOut.

Fixes https://github.com/PCSX2/pcsx2/issues/3124

* spu2-x: Create non-empty defaults for OutputApi and SdlOutputApi.

cmake: Change FreeBSD wx-config path

pcsx2|utilities: Remove ambiguous wxString-related overloads

Avoid some function overloads that can accept char*, wxChar* and
wxString as a parameter. wxString can be constructed with either of
those parameters, so the function overloads may actually result in
ambiguity errors. Keep the wxString parameter versions and remove the
rest.

Fixes some compile errors on FreeBSD.

utilities: Split thread internal callback function

__try is used in pthread_cleanup_push when CLEANUP_SET is used as the
pthread cleanup model. That can't be used in functions with objects that
have destructors, so move it into a separate function.

Prevents compile errors on non-release Windows builds if other things in
the internal callback function change.

GameDB: Asobo VU Rounding mode fixes (#3129)

This commit adds VU rounding modes (Positive) to Asobo games (Disney-Pixar WALL-E, Disney-Pixar Toy Story 3) which produces small lines in game.
Also add missing PAL entries to DB for Disney-Pixar WALL-E.

GameDB: Fahrenheit asylum crashing fixes. (#3109)

This commit add a patch to solve a crash in the game "Fahrenheit".

Found with the help of the dev-9 plugin and the PS4 emu.

This is a game bug trigger by a timing issue. The game have an internal crash reporting system
which rely on a debug server connected to the console.

When the game do an error, it expects the debug server to be connected to send the crash dump.

But that never happen on PCSX2 as the debug server is not present.

Thus, the game will enter in an infinite loop at the asylum level.

This only happen when certain conditions are meet in the game.

This patch makes the game to exit the loop by cancelling the debug reporting.

On top of that the game have no frame pacing system in place which causes a massive slowdown in loading screens.

Thankfully, this can be patched out.

Note: NTSC version is fine and doesn't require the patch.

Tested by atomic83github

gsdx-ogl: Hit unsafe instead of safe path for sw fbmask when there is no alpha blending. (#3100)

So far notable performance improvement show Spiderman 3 and Scarface of 1-2 fps when using basic blending. Full list of known affected games at #3100

gsdx_legacy: Silence very verbose clang warnings. (#3126)

[107/641] Building CXX object plugins/GSdx_legacy/CMakeFiles/GSdx-legacy-1.0.0.dir/stdafx.cpp.o
warning: unknown warning option '-Wno-class-memaccess'; did you mean '-Wno-class-varargs'? [-Wunknown-warning-option]
warning: unknown warning option '-Wno-packed-not-aligned'; did you mean '-Wno-over-aligned'? [-Wunknown-warning-option]
2 warnings generated.

Set F4's AlsoApplyToGui to false to avoid a hang when spammed.

common: Fix build error with clang 9. (#3123)

clang 9 now provides _rotr and _rotl.

pcsx2: Partially fix IPU PACK command

The pack command converts from RGB32 to RGB16/INDX4, not RAW8 to
RGB16/INDX4.

Also, the VQ conversion (still unimplemented) only occurs when the
output format is 0, so fix that as well.

Onepad: Update to latest controller database.

cmake: Fix build with cmake-3.5.2. (#3117)

cdvdgigaherz: Prevent potential infinite loop on ini read

Fixes a condition where a file read error could cause an infinite loop.

pcsx2: Fix parsing error in pointer patch command (#3112)

Fixes a type 6 (pointer) code parsing error that resulted in codes
with more than one offset getting terminated early.

gsdx-gui: Fix FXAA Shader checkbox not working properly.

Bonus: Remove unused "ModeRefreshRate" ini setting, leftover from d3d9,
psx option.